Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Add Facebook\HHAST\HHClientLinter to extraLinters #413

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Nov 26, 2021

Even though we don't want to include HHClientLinter in the NON_DEFAULT_LINTERS for now, it is still beneficial to dogfood the linter in the hhast repository. This PR is based on #411 and additionally add Facebook\HHAST\HHClientLinter to extraLinters

fredemmott and others added 2 commits November 26, 2021 09:08
This enables it with the `all` option, but hhvm#408 and hhvm#409 are release blockers

It should be possible to enable this just for HHAST via `extraLinters` in the config, in a followup, but on vacation atm so doing the minimum here to get `main` back to a releasable state
@Atry Atry merged commit 06353b7 into hhvm:main Nov 30, 2021
@Atry Atry deleted the hh-client-linter-remove-from-al branch November 30, 2021 08:30
Atry added a commit to Atry/hhast that referenced this pull request Dec 9, 2021
Atry added a commit to Atry/hhast that referenced this pull request Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants