feat: use baseUrl to display full URL #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hg-pyun
reviewed
Oct 19, 2021
alexandre-abrioux
force-pushed
the
feat-baseUrl
branch
3 times, most recently
from
2bff60f to
96b3531
Compare
|
Just forgot to update |
hg-pyun
reviewed
Oct 29, 2021
src/logger/response.ts
Outdated
| const buildConfig = assembleBuildConfig(config); | ||
|
|
||
| const stringBuilder = new StringBuilder(buildConfig); | ||
| const log = stringBuilder | ||
| .makeLogTypeWithPrefix('Response') | ||
| .makeDateFormat(new Date()) | ||
| .makeMethod(method) | ||
| .makeUrl(url) | ||
| .makeUrl(stringBuilder.combineURLs(baseURL, url)) |
There was a problem hiding this comment.
MakeUrl is an abstract method of logic that manages url. I think the combine URLs business logic should be inside makeUrl.
How about .makeUrl(url, baseUrl)?
There was a problem hiding this comment.
Sure! done :)
There was a problem hiding this comment.
Good. I will test and merge. Thank you.
alexandre-abrioux
force-pushed
the
feat-baseUrl
branch
from
96b3531 to
5f1ba4e
Compare
alexandre-abrioux
force-pushed
the
feat-baseUrl
branch
from
5f1ba4e to
841b9ed
Compare
hg-pyun
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #60 and takes into consideration the
baseURLparameter of an axios instance.