chore(deps): migrate to hcloud-go v2 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nywilken @lbajolet-hashicorp Can you take a look at this? Our deadline for the API deprecation is approaching soon. |
|
Hi @apricote, Understood, I see in the blogpost you linked that the depreciation is coming up by the end of this week, I'll read your PR today, and if good we'll merge this by EOD. Sorry for letting that one drag a bit long, thanks for pushing that. |
lbajolet-hashicorp
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Looks good to me, let's merge this now.
Thanks for this @apricote !
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates
hetznercloud/hcloud-gov1 to v2. This new major version was necessary because the Hetzner Cloud API will start returning up to 52 bit IDs soon.@hashicorp/packer it would be nice if we can get a new release with this change.