Change time variable type to float #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghsdh3409
force-pushed
the
float-current-time-android
branch
from
174ba26 to
31a24fb
Compare
ghsdh3409
commented
Mar 31, 2018
| @@ -123,7 +123,7 @@ public void playerViewDidBecomeReady() { | |||
| public void didChangeToSeeking(int milliSeconds) { | |||
| WritableMap event = Arguments.createMap(); | |||
| event.putString("state", "seeking"); | |||
| event.putInt("currentTime", milliSeconds / 1000); | |||
| event.putDouble("currentTime", milliSeconds / 1000.0); | |||
There was a problem hiding this comment.
Checked. Thanks! Little interesting that the original author used sometime milliSecs and sometimes secs.
|
@ohtangza I will merge this pull request without your review to test this! (Test is little inconvenient since podspec...) |
ohtangza
reviewed
Mar 31, 2018
| @@ -123,7 +123,7 @@ public void playerViewDidBecomeReady() { | |||
| public void didChangeToSeeking(int milliSeconds) { | |||
| WritableMap event = Arguments.createMap(); | |||
| event.putString("state", "seeking"); | |||
| event.putInt("currentTime", milliSeconds / 1000); | |||
| event.putDouble("currentTime", milliSeconds / 1000.0); | |||
There was a problem hiding this comment.
Checked. Thanks! Little interesting that the original author used sometime milliSecs and sometimes secs.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed all of variable type related to time to float.