Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f/aws_codebuild_project: enable build status config #15445

Closed
wants to merge 1 commit into from
Closed

f/aws_codebuild_project: enable build status config #15445

wants to merge 1 commit into from

Conversation

nikhil-goenka
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #15441

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeBuildProject_Source_BuildStatusConfig'
--- PASS: TestAccAWSCodeBuildProject_Source_BuildStatusConfig (191.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	193.975s
...

@nikhil-goenka nikhil-goenka requested a review from a team October 2, 2020 06:39
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/codebuild Issues and PRs that pertain to the codebuild service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 2, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 2, 2020
nikhil-goenka
nikhil-goenka commented Oct 2, 2020
View reviewed changes
aws/resource_aws_codebuild_project_test.go
@@ -2892,6 +2927,60 @@ resource "aws_codebuild_project" "test" {
`, rName, authResource, authType)
}

func testAccAWSCodeBuildProjectConfig_Source_BuildStatusConfig(rName string) string {
return testAccAWSCodeBuildProjectConfig_Base_ServiceRole(rName) + fmt.Sprintf(`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bflad : Hi Brian, there is a terrafmt error here, but I am not sure how to rectify it, I tried running terrfmt locally and it didn't show any difference for this file. your thoughts ?

@DrFaust92
Copy link
Collaborator

Duplicate of #15442

@DrFaust92 DrFaust92 marked this as a duplicate of #15442 Oct 3, 2020
Base automatically changed from master to main January 23, 2021 00:59
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:59
@ewbankkit
Copy link
Contributor

ewbankkit commented Apr 29, 2021 •
edited
Loading

@nikhil-goenka Thanks for the contribution 👏.
There is a duplicate PR (#15442) with fewer conflicts that will allow a quicker merge.
Closing this one.

@ewbankkit ewbankkit closed this Apr 29, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 29, 2021
@nikhil-goenka nikhil-goenka deleted the f/aws_codebuild_project-build-status-config branch April 29, 2021 13:59
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/codebuild Issues and PRs that pertain to the codebuild service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CodeBuild support "Build status config" in source config
3 participants
@nikhil-goenka @DrFaust92 @ewbankkit