r/datasync_task - add scheduling support

.changelog/14452.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+resource/aws_datasync_task: Add plan time validation to `cloudwatch_log_group_arn`, `destination_location_arn` and `source_location_arn`
+```
+
+```release-note:enhancement
+resource/aws_datasync_task: Add `schedule` argument
+```

aws/internal/service/datasync/finder/finder.go

@@ -0,0 +1,36 @@
+package finder
+
+import (
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/service/datasync"
+	"github.com/hashicorp/aws-sdk-go-base/tfawserr"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+)
+
+func TaskByARN(conn *datasync.DataSync, arn string) (*datasync.DescribeTaskOutput, error) {
+	input := &datasync.DescribeTaskInput{
+		TaskArn: aws.String(arn),
+	}
+
+	output, err := conn.DescribeTask(input)
+
+	if tfawserr.ErrMessageContains(err, datasync.ErrCodeInvalidRequestException, "not found") {
+		return nil, &resource.NotFoundError{
+			LastError:   err,
+			LastRequest: input,
+		}
+	}
+
+	if err != nil {
+		return nil, err
+	}
+
+	if output == nil {
+		return nil, &resource.NotFoundError{
+			Message:     "Empty result",
+			LastRequest: input,
+		}
+	}
+
+	return output, nil
+}

aws/internal/service/datasync/waiter/status.go

@@ -3,33 +3,21 @@ package waiter
 import (
 	"github.com/aws/aws-sdk-go/aws"
 	"github.com/aws/aws-sdk-go/service/datasync"
-	"github.com/hashicorp/aws-sdk-go-base/tfawserr"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+	"github.com/terraform-providers/terraform-provider-aws/aws/internal/service/datasync/finder"
+	"github.com/terraform-providers/terraform-provider-aws/aws/internal/tfresource"
 )
 
-const (
-	TaskStatusUnknown = "Unknown"
-)
-
-// TaskStatus fetches the Operation and its Status
 func TaskStatus(conn *datasync.DataSync, arn string) resource.StateRefreshFunc {
 	return func() (interface{}, string, error) {
-		input := &datasync.DescribeTaskInput{
-			TaskArn: aws.String(arn),
-		}
+		output, err := finder.TaskByARN(conn, arn)
 
-		output, err := conn.DescribeTask(input)
-
-		if tfawserr.ErrMessageContains(err, datasync.ErrCodeInvalidRequestException, "not found") {
+		if tfresource.NotFound(err) {
 			return nil, "", nil
 		}
 
 		if err != nil {
-			return output, TaskStatusUnknown, err
-		}
-
-		if output == nil {
-			return output, TaskStatusUnknown, nil
+			return nil, "", err
 		}
 
 		return output, aws.StringValue(output.Status), nil

aws/internal/service/datasync/waiter/waiter.go

@@ -10,17 +10,10 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 )
 
-// TaskStatusAvailable waits for a Task to return Available
-func TaskStatusAvailable(conn *datasync.DataSync, arn string, timeout time.Duration) (*datasync.DescribeTaskOutput, error) {
+func TaskAvailable(conn *datasync.DataSync, arn string, timeout time.Duration) (*datasync.DescribeTaskOutput, error) {
 	stateConf := &resource.StateChangeConf{
-		Pending: []string{
-			datasync.TaskStatusCreating,
-			datasync.TaskStatusUnavailable,
-		},
-		Target: []string{
-			datasync.TaskStatusAvailable,
-			datasync.TaskStatusRunning,
-		},
+		Pending: []string{datasync.TaskStatusCreating, datasync.TaskStatusUnavailable},
+		Target:  []string{datasync.TaskStatusAvailable, datasync.TaskStatusRunning},
 		Refresh: TaskStatus(conn, arn),
 		Timeout: timeout,
 	}