Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import test refactor for DX resources #10571

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Import test refactor for DX resources #10571

merged 1 commit into from
Oct 29, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

make testacc TESTARGS="-run=TestAccAWSDxConnection_"     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSDxConnection_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDxConnection_basic
=== PAUSE TestAccAWSDxConnection_basic
=== RUN   TestAccAWSDxConnection_tags
=== PAUSE TestAccAWSDxConnection_tags
=== CONT  TestAccAWSDxConnection_basic
=== CONT  TestAccAWSDxConnection_tags
--- PASS: TestAccAWSDxConnection_basic (40.44s)
--- PASS: TestAccAWSDxConnection_tags (60.99s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       62.422s

make testacc TESTARGS="-run=TestAccAwsDxGateway_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAwsDxGateway_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAwsDxGateway_basic
=== PAUSE TestAccAwsDxGateway_basic
=== RUN   TestAccAwsDxGateway_complex
=== PAUSE TestAccAwsDxGateway_complex
=== CONT  TestAccAwsDxGateway_basic
=== CONT  TestAccAwsDxGateway_complex
--- PASS: TestAccAwsDxGateway_basic (50.14s)
--- PASS: TestAccAwsDxGateway_complex (1218.72s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1220.152s

make testacc TESTARGS="-run=TestAccAWSDxLag_"     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSDxLag_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDxLag_basic
=== PAUSE TestAccAWSDxLag_basic
=== RUN   TestAccAWSDxLag_tags
=== PAUSE TestAccAWSDxLag_tags
=== CONT  TestAccAWSDxLag_basic
=== CONT  TestAccAWSDxLag_tags
--- PASS: TestAccAWSDxLag_basic (62.31s)
--- PASS: TestAccAWSDxLag_tags (82.70s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       84.119s

@ryndaniels ryndaniels requested review from bflad and a team October 21, 2019 10:18
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/directconnect Issues and PRs that pertain to the directconnect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 21, 2019
@bflad bflad self-assigned this Oct 25, 2019
@bflad bflad added this to the v2.34.0 milestone Oct 28, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSDxConnectionAssociation_basic (23.84s)
--- PASS: TestAccAWSDxConnection_basic (24.24s)
--- PASS: TestAccAWSDxConnectionAssociation_multiConns (24.95s)
--- PASS: TestAccAWSDxLag_basic (29.12s)
--- PASS: TestAccAWSDxConnection_tags (29.32s)
--- PASS: TestAccAWSDxLag_tags (27.58s)
--- PASS: TestAccAwsDxGateway_basic (98.07s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_VpnGatewayId (106.21s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_disappears (106.48s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_basicVpnGateway (107.17s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_AllowedPrefixes (109.12s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_basicTransitGateway (173.62s)
--- PASS: TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount (1032.72s)
--- PASS: TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount (1037.73s)
--- PASS: TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount (1306.47s)
--- PASS: TestAccAwsDxGateway_complex (1310.98s)
--- PASS: TestAccAwsDxGatewayAssociation_basicVpnGatewayCrossAccount (1313.31s)
--- PASS: TestAccAwsDxGatewayAssociation_deprecatedSingleAccount (1390.75s)
--- PASS: TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount (1454.09s)
--- PASS: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount (1652.38s)
--- PASS: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount (1816.61s)

@ryndaniels ryndaniels merged commit 208f4d9 into master Oct 29, 2019
@ryndaniels ryndaniels deleted the rfd-at002-dx branch October 29, 2019 09:14
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/directconnect Issues and PRs that pertain to the directconnect service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants