-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F/resource aws codestarconnections connection - support for host_arn #19284
F/resource aws codestarconnections connection - support for host_arn #19284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsCodeStarConnectionsConnection_\|TestAccAWSCodeStarConnectionsConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsCodeStarConnectionsConnection_\|TestAccAWSCodeStarConnectionsConnection_ -timeout 180m
=== RUN TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== PAUSE TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== RUN TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== PAUSE TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== RUN TestAccAWSCodeStarConnectionsConnection_Basic
=== PAUSE TestAccAWSCodeStarConnectionsConnection_Basic
=== RUN TestAccAWSCodeStarConnectionsConnection_HostArn
=== PAUSE TestAccAWSCodeStarConnectionsConnection_HostArn
=== RUN TestAccAWSCodeStarConnectionsConnection_disappears
=== PAUSE TestAccAWSCodeStarConnectionsConnection_disappears
=== RUN TestAccAWSCodeStarConnectionsConnection_Tags
=== PAUSE TestAccAWSCodeStarConnectionsConnection_Tags
=== CONT TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== CONT TestAccAWSCodeStarConnectionsConnection_disappears
=== CONT TestAccAWSCodeStarConnectionsConnection_Tags
=== CONT TestAccAWSCodeStarConnectionsConnection_Basic
=== CONT TestAccAWSCodeStarConnectionsConnection_HostArn
=== CONT TestAccDataSourceAwsCodeStarConnectionsConnection_tags
--- PASS: TestAccAWSCodeStarConnectionsConnection_disappears (12.83s)
--- PASS: TestAccDataSourceAwsCodeStarConnectionsConnection_basic (16.55s)
--- PASS: TestAccDataSourceAwsCodeStarConnectionsConnection_tags (16.75s)
--- PASS: TestAccAWSCodeStarConnectionsConnection_Basic (17.20s)
--- PASS: TestAccAWSCodeStarConnectionsConnection_HostArn (19.83s)
--- PASS: TestAccAWSCodeStarConnectionsConnection_Tags (36.73s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 39.811s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsCodeStarConnectionsConnection_\|TestAccAWSCodeStarConnectionsConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsCodeStarConnectionsConnection_\|TestAccAWSCodeStarConnectionsConnection_ -timeout 180m
=== RUN TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== PAUSE TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== RUN TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== PAUSE TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== RUN TestAccAWSCodeStarConnectionsConnection_Basic
=== PAUSE TestAccAWSCodeStarConnectionsConnection_Basic
=== RUN TestAccAWSCodeStarConnectionsConnection_HostArn
=== PAUSE TestAccAWSCodeStarConnectionsConnection_HostArn
=== RUN TestAccAWSCodeStarConnectionsConnection_disappears
=== PAUSE TestAccAWSCodeStarConnectionsConnection_disappears
=== RUN TestAccAWSCodeStarConnectionsConnection_Tags
=== PAUSE TestAccAWSCodeStarConnectionsConnection_Tags
=== CONT TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== CONT TestAccAWSCodeStarConnectionsConnection_Tags
=== CONT TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== CONT TestAccAWSCodeStarConnectionsConnection_HostArn
=== CONT TestAccAWSCodeStarConnectionsConnection_disappears
=== CONT TestAccAWSCodeStarConnectionsConnection_Basic
=== CONT TestAccDataSourceAwsCodeStarConnectionsConnection_tags
provider_test.go:721: skipping tests; partition aws-us-gov does not support codestar-connections service
=== CONT TestAccAWSCodeStarConnectionsConnection_Tags
provider_test.go:721: skipping tests; partition aws-us-gov does not support codestar-connections service
--- SKIP: TestAccDataSourceAwsCodeStarConnectionsConnection_tags (2.40s)
--- SKIP: TestAccAWSCodeStarConnectionsConnection_Tags (2.40s)
=== CONT TestAccDataSourceAwsCodeStarConnectionsConnection_basic
provider_test.go:721: skipping tests; partition aws-us-gov does not support codestar-connections service
--- SKIP: TestAccDataSourceAwsCodeStarConnectionsConnection_basic (2.40s)
=== CONT TestAccAWSCodeStarConnectionsConnection_disappears
provider_test.go:721: skipping tests; partition aws-us-gov does not support codestar-connections service
--- SKIP: TestAccAWSCodeStarConnectionsConnection_disappears (2.40s)
=== CONT TestAccAWSCodeStarConnectionsConnection_Basic
provider_test.go:721: skipping tests; partition aws-us-gov does not support codestar-connections service
--- SKIP: TestAccAWSCodeStarConnectionsConnection_Basic (2.40s)
=== CONT TestAccAWSCodeStarConnectionsConnection_HostArn
provider_test.go:721: skipping tests; partition aws-us-gov does not support codestar-connections service
--- SKIP: TestAccAWSCodeStarConnectionsConnection_HostArn (2.40s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 6.897s
@nikhil-goenka Thanks for the contribution 👏. |
This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #17592.
Output from acceptance testing: