Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GitHubEnterpriseServer codestarconnections_host on codestarconnections_connection #17592

Closed
Meroje opened this issue Feb 12, 2021 · 2 comments · Fixed by #19284
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codestarconnections Issues and PRs that pertain to the codestarconnections service.
Milestone

Comments

@Meroje
Copy link

Meroje commented Feb 12, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v0.14.6
+ provider registry.terraform.io/hashicorp/aws v3.27.0

Affected Resource(s)

  • aws_codestarconnections_connection

Terraform Configuration Files

Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.

resource "aws_codestarconnections_connection" "test" {
  name          = "testconnection"
  provider_type = "GitHubEnterpriseServer"
}

Debug Output

https://gist.github.com/Meroje/373550cc543e26359fa27028136bbad9

Panic Output

Expected Behavior

Well in the current state of the provider I can't expect this to work (but it still is documented so..). When #16918 lands I expect to be able to add an host_arn on the resource above as instructed by the api response.

Actual Behavior

Nothing is created, terraform returns with the following API error

Error: error creating CodeStar connection: ValidationException: To use a hosted provider specify HostArn instead of ProviderType

Steps to Reproduce

  1. terraform apply

Important Factoids

References

@ghost ghost added the service/codestarconnections Issues and PRs that pertain to the codestarconnections service. label Feb 12, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 12, 2021
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 29, 2021
@github-actions github-actions bot added this to the v3.40.0 milestone May 10, 2021
@ghost
Copy link

ghost commented May 13, 2021

This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codestarconnections Issues and PRs that pertain to the codestarconnections service.
Projects
None yet
2 participants