-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: EC2 Image Builder Distribution Configuration #13316
Comments
Is this a dupe of #11084? That one appears to encompass the full service. |
Hi @iancward, it's not a dupe I'm just breaking it out into separate resources. It's easier for us to track that way, and easier for contributors to pick up a single resource. 👍 |
Might be resolved by #13485 |
Reference: #11084 Reference: #13316 Reference: #13485 Changes: ``` * **New Data Source:** `aws_imagebuilder_distribution_configuration` * **New Resource:** `aws_imagebuilder_distribution_configuration` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderDistributionConfiguration_basic (23.95s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Description (39.52s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_disappears (18.57s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution (42.99s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags (40.02s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description (39.36s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId (46.31s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups (23.66s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds (40.12s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name (39.12s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds (40.12s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns (40.75s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Tags (49.75s) --- PASS: TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn (18.52s) ``` Output from acceptance testing in AWS GovCloud (US) (failure information: #16178): ``` --- FAIL: TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns (10.88s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_basic (27.00s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Description (40.22s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_disappears (21.76s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags (42.09s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description (42.89s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId (51.80s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups (26.70s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds (41.44s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name (42.32s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds (42.42s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Tags (55.37s) --- PASS: TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn (25.62s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/13 09:11:34 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/13 09:11:34 [DEBUG] Running Sweeper (aws_imagebuilder_distribution_configuration) in region (us-west-2) 2020/11/13 09:11:37 Sweeper Tests ran successfully: - aws_imagebuilder_distribution_configuration 2020/11/13 09:11:37 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/13 09:11:37 [DEBUG] Running Sweeper (aws_imagebuilder_distribution_configuration) in region (us-east-1) 2020/11/13 09:11:39 Sweeper Tests ran successfully: - aws_imagebuilder_distribution_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 7.724s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/13 09:30:11 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/13 09:30:11 [DEBUG] Running Sweeper (aws_imagebuilder_distribution_configuration) in region (us-gov-west-1) 2020/11/13 09:30:14 Sweeper Tests ran successfully: - aws_imagebuilder_distribution_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 4.971s ```
* Add aws_imagebuilder_component * Add test for data_source_aws_imagebuilder_component * Add aws_imagebuilder_infrastructureconfiguration * Add aws_imagebuilder_recipe * Rename to aws_imagebuilder_infrastructure_configuration * Fix issue with infraconfig logging * Fix incorrect MaxItems on res * Fix S024 * Fix AWSR002 * Fix linting * [#11084] Fix the imagebuilder resource, add test and docs # Conflicts: # aws/provider.go * Fix incorrect import on error handling * Update to v2 SDK * Fix R004 lint issue * Remove changes to aws.erb * Add imagebuilder_distribution_configuration * Add imagebuilder_image_pipeline * fixed some lint issues and fixed terminate_instance_on_failure not being set on create * description can be updated in place * service/imagebuilder: Remove non-aws_imagebuilder_distribution_configuration files * New Resource: aws_imagebuilder_distribution_configuration Reference: #11084 Reference: #13316 Reference: #13485 Changes: ``` * **New Data Source:** `aws_imagebuilder_distribution_configuration` * **New Resource:** `aws_imagebuilder_distribution_configuration` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderDistributionConfiguration_basic (23.95s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Description (39.52s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_disappears (18.57s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution (42.99s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags (40.02s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description (39.36s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId (46.31s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups (23.66s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds (40.12s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name (39.12s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds (40.12s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns (40.75s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Tags (49.75s) --- PASS: TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn (18.52s) ``` Output from acceptance testing in AWS GovCloud (US) (failure information: #16178): ``` --- FAIL: TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns (10.88s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_basic (27.00s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Description (40.22s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_disappears (21.76s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags (42.09s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description (42.89s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId (51.80s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups (26.70s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds (41.44s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name (42.32s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds (42.42s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Tags (55.37s) --- PASS: TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn (25.62s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/13 09:11:34 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/13 09:11:34 [DEBUG] Running Sweeper (aws_imagebuilder_distribution_configuration) in region (us-west-2) 2020/11/13 09:11:37 Sweeper Tests ran successfully: - aws_imagebuilder_distribution_configuration 2020/11/13 09:11:37 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/13 09:11:37 [DEBUG] Running Sweeper (aws_imagebuilder_distribution_configuration) in region (us-east-1) 2020/11/13 09:11:39 Sweeper Tests ran successfully: - aws_imagebuilder_distribution_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 7.724s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/13 09:30:11 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/13 09:30:11 [DEBUG] Running Sweeper (aws_imagebuilder_distribution_configuration) in region (us-gov-west-1) 2020/11/13 09:30:14 Sweeper Tests ran successfully: - aws_imagebuilder_distribution_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 4.971s ``` * docs/resource/aws_imagebuilder_distribution_configuration: Fix typo Co-authored-by: Dogers <[email protected]> Co-authored-by: Jakub Kania <[email protected]> Co-authored-by: Bill Schneider <[email protected]>
A new |
This has been released in version 3.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Description
In December 2019 AWS announced the availability of EC2 ImageBuilder, a service that makes it easier and faster to build and maintain secure images. Image Builder simplifies the creation, patching, testing, distribution, and sharing of Linux or Windows Server images.
New Resource
Potential Terraform Configuration
References
Announcement: https://aws.amazon.com/about-aws/whats-new/2019/12/introducing-ec2-image-builder/
API Reference: https://docs.aws.amazon.com/imagebuilder/latest/APIReference/Welcome.html
SDK Reference: https://docs.aws.amazon.com/sdk-for-go/api/service/imagebuilder/
The text was updated successfully, but these errors were encountered: