Skip to content

Commit

Permalink
Merge pull request #16608 from with-joy/f-increased_retention_period_…
Browse files Browse the repository at this point in the history
…for_kinesis_streams

increased max retention period for kinesis stream to 8760
  • Loading branch information
anGie44 authored Dec 22, 2020
2 parents f7e700d + f05b945 commit 4c00888
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion aws/resource_aws_kinesis_stream.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func resourceAwsKinesisStream() *schema.Resource {
Type: schema.TypeInt,
Optional: true,
Default: 24,
ValidateFunc: validation.IntBetween(24, 168),
ValidateFunc: validation.IntBetween(24, 8760),
},

"shard_level_metrics": {
Expand Down
4 changes: 2 additions & 2 deletions aws/resource_aws_kinesis_stream_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ func TestAccAWSKinesisStream_retentionPeriod(t *testing.T) {
testAccCheckKinesisStreamExists(resourceName, &stream),
testAccCheckAWSKinesisStreamAttributes(&stream),
resource.TestCheckResourceAttr(
resourceName, "retention_period", "100"),
resourceName, "retention_period", "8760"),
),
},

Expand Down Expand Up @@ -663,7 +663,7 @@ func testAccKinesisStreamConfigUpdateRetentionPeriod(rInt int) string {
resource "aws_kinesis_stream" "test" {
name = "terraform-kinesis-test-%d"
shard_count = 2
retention_period = 100
retention_period = 8760
tags = {
Name = "tf-test"
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/kinesis_stream.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ The following arguments are supported:
* `name` - (Required) A name to identify the stream. This is unique to the AWS account and region the Stream is created in.
* `shard_count` – (Required) The number of shards that the stream will use.
Amazon has guidelines for specifying the Stream size that should be referenced when creating a Kinesis stream. See [Amazon Kinesis Streams][2] for more.
* `retention_period` - (Optional) Length of time data records are accessible after they are added to the stream. The maximum value of a stream's retention period is 168 hours. Minimum value is 24. Default is 24.
* `retention_period` - (Optional) Length of time data records are accessible after they are added to the stream. The maximum value of a stream's retention period is 8760 hours. Minimum value is 24. Default is 24.
* `shard_level_metrics` - (Optional) A list of shard-level CloudWatch metrics which can be enabled for the stream. See [Monitoring with CloudWatch][3] for more. Note that the value ALL should not be used; instead you should provide an explicit list of metrics you wish to enable.
* `enforce_consumer_deletion` - (Optional) A boolean that indicates all registered consumers should be deregistered from the stream so that the stream can be destroyed without error. The default value is `false`.
* `encryption_type` - (Optional) The encryption type to use. The only acceptable values are `NONE` or `KMS`. The default value is `NONE`.
Expand Down

0 comments on commit 4c00888

Please sign in to comment.