Test logging no longer affects retrieval of file name and line number #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if any logging is in the output of the test before the assert failure, the file name and line number is not detected properly causing GitHub to not be able to do the annotations. This change makes it so the assert failures are extracted (using regex), and then the file name and line number is extracted from that.
For example, a Go test with the following code on in
main_test.go
with the failure on line 18:used to cause Github to receive the annotation text:
and now it would receive:
Example tests for this change can be seen here (along with tests that can be ran locally if needed using https://github.com/nektos/act): https://github.com/IsaacLambat/golang-test-annotations-testing
Example of annotations on a PR: https://github.com/IsaacLambat/golang-test-annotations-testing/pull/1/files