Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReleaseGroup] Romaji title - S01E01 [1080p HEVC x265 10Bit] (English title) has incorrect Release Group #696

Open
reconman opened this issue Apr 27, 2021 · 6 comments

Comments

@reconman
Copy link

[ASW] Fumetsu no Anata e - S01E03 [1080p HEVC x265 10Bit][AAC] (To Your Eternity) is detected as Release Group = To Your Eternity.

This new naming format is used by a few Release Groups so their torrents can be found more easily.

The release group is still always in the first square brackets.

@Toilal
Copy link
Member

Toilal commented Apr 29, 2021

It's not an easy fix.

Currently guessit makes no difference between parentheses and brackets. So this use case is virtually the same as [ASW] Fumetsu no Anata e - S01E03 [1080p HEVC x265 10Bit][AAC] [To Your Eternity].

I'm pretty sure you could also find some releases using reverse scheme ordering, something like [To Your Eternity] Fumetsu no Anata e - S01E03 [1080p HEVC x265 10Bit][AAC] [ASW].

So It seems impossible to find an algorithm that would guess the release group in any case ... Maybe we could give some priority on brackets for release_group, but i'm pretty sure some users will open an issue because the release_group would be wrongly detected when it's enclosed by parentheses.

I would really love guessit be smarter to guess release_group, but i'm not sure it's possible.

@reconman
Copy link
Author

Related: [YakuboEncodes] Fumetsu no Anata e (To Your Eternity) - 03 [1080p 10bit][x265 HEVC][Multi-Subs] is detected as release group Multi-Subs

@Toilal
Copy link
Member

Toilal commented Apr 29, 2021

Multi-Subs should be guessed as a subtitle_language: Multiple languages

@Toilal
Copy link
Member

Toilal commented Apr 29, 2021

It seems to work on develop here.

For: [YakuboEncodes] Fumetsu no Anata e (To Your Eternity) - 03 [1080p 10bit][x265 HEVC][Multi-Subs]
GuessIt found: {
    "release_group": "YakuboEncodes",
    "title": "Fumetsu no Anata e",
    "episode": 3,
    "screen_size": "1080p",
    "color_depth": "10-bit",
    "video_codec": "H.265",
    "video_profile": "High Efficiency Video Coding",
    "subtitle_language": [
        "Multiple languages",
        "und"
    ],
    "type": "episode"
}

@reconman
Copy link
Author

reconman commented Apr 29, 2021

Sorry, took a wrong release, here's one that actually didn't work: [Erai-raws] Fumetsu no Anata e - 03 [720p][Multiple Subtitle].mkv

@Toilal
Copy link
Member

Toilal commented Apr 30, 2021

f19cfda partialy fixes the issue, but not for the first use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants