add config example #788
add config example #788
Conversation
james03160927
force-pushed
the
config-example
branch
from
4594ee6 to
ed71ced
Compare
aws/resource_registry.go
Outdated
| @@ -64,7 +64,6 @@ func getRegisteredRegionalResources() []AwsResource { | |||
| &resources.AppRunnerService{}, | |||
| &resources.BackupVault{}, | |||
| &resources.ManagedPrometheus{}, | |||
| &resources.Grafana{}, | |||
There was a problem hiding this comment.
can you rebase? both Grafana and ElasticCacheServerless where already merge
james03160927
force-pushed
the
config-example
branch
from
a66ceb6 to
f498908
Compare
There was a problem hiding this comment.
Hi all, I just saw this was approved now. Please note my comments here and here.
I don't know what happened. They were initially fixed when I made these comments and the conversation resolved, but now it seems like those commits have disappeared. Could you take a look at that before merging, please? Thanks!
Hmm not sure what happened there but it's resolved now. |
|
Hey @denis256, can you please approve the PR once again? |
Description
fixes #786.
TODOs
Read the Gruntwork contribution guidelines.
nuke_sandboxandnuke_phxdevopsjobs in.circleci/config.ymlhave been updated with appropriate exclusions (either directly in the job or via the.circleci/nuke_config.ymlfile) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide