Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to AWS SDK v2 for secrets manager, rds, and sagemaker modules #785

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

james03160927
Copy link
Contributor

Description

Fixes #770.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@james03160927 james03160927 force-pushed the migration/rds-sagemaker-screts branch 2 times, most recently from d509271 to 89ac6e7 Compare November 12, 2024 01:19
@james03160927 james03160927 force-pushed the migration/rds-sagemaker-screts branch from 89ac6e7 to 06de82e Compare November 25, 2024 22:42
@james03160927 james03160927 force-pushed the migration/rds-sagemaker-screts branch from 06de82e to ed47fa4 Compare November 25, 2024 22:55
@james03160927 james03160927 merged commit 9174dbc into master Nov 27, 2024
3 checks passed
@james03160927 james03160927 deleted the migration/rds-sagemaker-screts branch November 27, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to AWS SDKv2
2 participants