migrate: aws v2 - vpc lattice #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james03160927
force-pushed
the
migrate/vpc-lattice
branch
2 times, most recently
from
0ee4078 to
f2715cd
Compare
|
hey @james03160927 can you run go generate ./...this should update the the |
james03160927
force-pushed
the
migrate/vpc-lattice
branch
from
b77275d to
efabc7e
Compare
denis256
reviewed
Oct 23, 2024
|
Hi @denis256, addressed your comments. PTAL. |
denis256
previously approved these changes
Oct 25, 2024
james03160927
force-pushed
the
migrate/vpc-lattice
branch
2 times, most recently
from
7bcaa30 to
ab10ec7
Compare
denis256
reviewed
Oct 28, 2024
|
|
||
| return nil | ||
| } | ||
| func (network *VPCLatticeService) waitUntilAllServiceAssociationDeleted(id *string) error { |
There was a problem hiding this comment.
Formatting still looks wrong
go fmt ./...
There was a problem hiding this comment.
Hmm should be good now? Can you check?
james03160927
force-pushed
the
migrate/vpc-lattice
branch
from
101a2e6 to
3f745f1
Compare
denis256
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially fixing #770
TODOs
Read the Gruntwork contribution guidelines.
nuke_sandboxandnuke_phxdevopsjobs in.circleci/config.ymlhave been updated with appropriate exclusions (either directly in the job or via the.circleci/nuke_config.ymlfile) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide