Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement egress only internet gateway nuke #657

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Implement egress only internet gateway nuke #657

merged 1 commit into from
Apr 2, 2024

Conversation

james03160927
Copy link
Contributor

Description

Partially Fixing #476

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

denis256
denis256 reviewed Mar 27, 2024
View reviewed changes
aws/resources/ec2_egress_only_igw.go Show resolved Hide resolved
aws/resources/ec2_egress_only_igw.go Outdated
}
}

// chgecking the nukable permissions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chgecking 🤔

aws/resources/ec2_egress_only_igw_test.go Show resolved Hide resolved
@james03160927 james03160927 force-pushed the 34/egress-only-network-gateway branch 2 times, most recently from c1991c3 to 8bb6f3b Compare March 29, 2024 18:02
@james03160927 james03160927 force-pushed the 34/egress-only-network-gateway branch from 8bb6f3b to d12c320 Compare March 29, 2024 18:11
@james03160927 james03160927 merged commit 3c3d3fb into master Apr 2, 2024
3 checks passed
@james03160927 james03160927 deleted the 34/egress-only-network-gateway branch April 2, 2024 00:43
@BrewTestBot BrewTestBot mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis256 denis256 denis256 approved these changes

@arsci arsci Awaiting requested review from arsci arsci is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james03160927 @denis256