Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't set custom collation with QueryBuilder.stringOrderCollation and SQLCipher #727

Closed
dvolodin opened this issue Jul 13, 2017 · 2 comments · Fixed by #730
Closed

Can't set custom collation with QueryBuilder.stringOrderCollation and SQLCipher #727

dvolodin opened this issue Jul 13, 2017 · 2 comments · Fixed by #730
Milestone
3.3.0

Comments

@dvolodin
Copy link

I've created (https://sqlite.org/c3ref/create_collation.html) and successfully registered a new collation algorithm, but this check prevents creation of queries that use it or any other collation but the default. Judging by this comment this seems intended only for preferLocalizedStringOrder.
greenrobot-team added a commit to greenrobot-team/greenDAO that referenced this issue Jul 17, 2017
@greenrobot-team
Allow collation for SQLCipher databases.
c85513d 
- Closes greenrobot#727.
- SQLCipher just does not support collation that requires Android libraries
  (like 'COLLATE LOCALIZED'). Everything else standard SQLite is supported,
  so allow it.
@greenrobot-team greenrobot-team mentioned this issue Jul 17, 2017
Merged
@greenrobot-team
Copy link
Collaborator

Thanks for reporting this. I submitted a patch (#730) to allow setting collations even if SQLCipher is used. -ut

@greenrobot-team greenrobot-team added this to the 3.x milestone May 7, 2018
@greenrobot-team greenrobot-team modified the milestones: 3.x, 3.3.0 Feb 18, 2020
@greenrobot-team
Copy link
Collaborator

3.3.0 has been released which includes the above change.
https://greenrobot.org/greendao/changelog/

diamondyhand added a commit to diamondyhand/green-DAO that referenced this issue Dec 15, 2023
@diamondyhand
Allow collation for SQLCipher databases.
c71b8c9 
- Closes greenrobot/greenDAO#727.
- SQLCipher just does not support collation that requires Android libraries
  (like 'COLLATE LOCALIZED'). Everything else standard SQLite is supported,
  so allow it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

Allow collation for SQLCipher databases. greenrobot-team/greenDAO
2 participants
@dvolodin @greenrobot-team