-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workload Identity: Add workload-identity-x509
service to tbot
#50812
base: master
Are you sure you want to change the base?
Conversation
workload-identity-x509
service to tbot
"The name of the workload identity to issue", | ||
).StringVar(&c.WorkloadIdentityName) | ||
cmd.Flag( | ||
"workload-identity-labels", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is --workload-identity-name
and --workload-identity-labels
too verbose? I was worried that just --name
/ --labels
would be not verbose enough. Perhaps --name-selector
/ --label-selector
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually curious about this exact question on #50898. I've so far gone with the unambiguous but way too verbose names following the pattern here, but was strongly considering the much shorter --name
and --labels
since users can probably infer meaning from context. Maybe there's some additional benefit knowing that e.g. --labels
can be reused across certain commands that accept selectors?
type WorkloadIdentityX509Service struct { | ||
// WorkloadIdentity is the selector for the WorkloadIdentity resource that | ||
// will be used to issue WICs. | ||
WorkloadIdentity WorkloadIdentitySelector `yaml:"workload_identity"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the JSON/YAML name of this field reference the "selector" nature of the field - e.g workload_identity_selector
or selector
?
Part of: #49986
As per RFD191: #49133
For now, this command is hidden until we remove the feature flag.
Follow up PRs will include the
workload-identity-api
andworkload-identity-jwt
services.