Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoking the Azure fetcher in the Discovery service #50369

Draft
wants to merge 6 commits into
base: mvbrock/azure-integration-disco-azure-sync
Choose a base branch
from

Conversation

mvbrock
Copy link
Contributor

@mvbrock mvbrock commented Dec 17, 2024

This PR is a result of splitting #48843 into smaller PRs, and invokes the Azure sync functionality with a new Azure fetcher in the Discovery service.

@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from 0d11394 to f4c8928 Compare December 18, 2024 20:31
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-srv branch from 48e471c to 995a28b Compare December 18, 2024 20:34
if err := s.initTAGAzureWatchers(s.ctx, cfg); err != nil {
return nil, trace.Wrap(err)
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From @marcoandredinis in #48843 (comment)

Can we either move the TAGAWSWatcher here or move the initTagAzure inside the initAccessGraphWatchers?

s.dynamicTAGAWSFetchers[dc.GetName()] = awsSyncMatchers
s.muDynamicTAGAWSFetchers.Unlock()

azureSyncMatchers, err := s.accessGraphAzureFetchersFromMatchers(matchers, dc.GetName())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From @marcoandredinis in #48843 (comment)

Can we rename the s.accessGraphFetchersFromMatchers( to be explicit about AWS Matchers for AccessGraph?

So, from accessGraphAzureFetchersFromMatchers to accessGraphAWSFetchersFromMatchers

@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from f4c8928 to 4fdb2cc Compare December 18, 2024 21:23
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-srv branch from 3af26e6 to 3f66376 Compare December 18, 2024 21:28
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch 2 times, most recently from 899c86f to 873db7c Compare December 20, 2024 02:17
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-srv branch from 3f66376 to 2330dbc Compare December 20, 2024 02:17
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from 873db7c to b2512a9 Compare December 20, 2024 02:54
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-srv branch 2 times, most recently from a8f5762 to 7f3efa4 Compare December 20, 2024 03:50
@mvbrock mvbrock marked this pull request as ready for review December 20, 2024 03:51
@github-actions github-actions bot requested a review from atburke December 20, 2024 03:51
@mvbrock mvbrock marked this pull request as draft December 20, 2024 03:52
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from b2512a9 to 1d807fb Compare December 20, 2024 22:08
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-srv branch from 7f3efa4 to 8264708 Compare December 20, 2024 22:08
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from 1d807fb to 02e6652 Compare December 20, 2024 22:29
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-srv branch from 8264708 to ea03cd5 Compare December 20, 2024 22:29
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from 02e6652 to 6b13db1 Compare December 31, 2024 17:35
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-srv branch from ea03cd5 to 5494298 Compare December 31, 2024 17:38
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from 043d3bd to cc487b0 Compare January 7, 2025 05:08
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-srv branch from 7d36613 to e774f8b Compare January 7, 2025 05:08
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from cc487b0 to 6d8806b Compare January 7, 2025 05:16
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-srv branch from e774f8b to 8380fa9 Compare January 7, 2025 05:17
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from 7bee98a to 92462b6 Compare January 7, 2025 16:44
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-srv branch from 8380fa9 to 41e4e93 Compare January 7, 2025 16:44
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from 92462b6 to 6c8b85e Compare January 9, 2025 06:17
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-srv branch from 41e4e93 to d651fd7 Compare January 9, 2025 06:36
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from c127aff to 604d3de Compare January 10, 2025 16:12
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-srv branch 2 times, most recently from 7c316ec to b43771a Compare January 10, 2025 16:45
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from 1a6e91d to dcc048c Compare January 10, 2025 17:00
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-srv branch from b43771a to 6c146c1 Compare January 10, 2025 17:00
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from dcc048c to 0301869 Compare January 10, 2025 17:09
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-srv branch from 6c146c1 to 94e1267 Compare January 10, 2025 17:09
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from 0301869 to bb1282e Compare January 10, 2025 17:15
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-srv branch from 55d1497 to 0725655 Compare January 10, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant