-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoking the Azure fetcher in the Discovery service #50369
base: mvbrock/azure-integration-disco-azure-sync
Are you sure you want to change the base?
Invoking the Azure fetcher in the Discovery service #50369
Conversation
0d11394
to
f4c8928
Compare
48e471c
to
995a28b
Compare
if err := s.initTAGAzureWatchers(s.ctx, cfg); err != nil { | ||
return nil, trace.Wrap(err) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From @marcoandredinis in #48843 (comment)
Can we either move the TAGAWSWatcher here or move the
initTagAzure
inside theinitAccessGraphWatchers
?
s.dynamicTAGAWSFetchers[dc.GetName()] = awsSyncMatchers | ||
s.muDynamicTAGAWSFetchers.Unlock() | ||
|
||
azureSyncMatchers, err := s.accessGraphAzureFetchersFromMatchers(matchers, dc.GetName()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From @marcoandredinis in #48843 (comment)
Can we rename the
s.accessGraphFetchersFromMatchers(
to be explicit about AWS Matchers for AccessGraph?So, from
accessGraphAzureFetchersFromMatchers
toaccessGraphAWSFetchersFromMatchers
f4c8928
to
4fdb2cc
Compare
3af26e6
to
3f66376
Compare
899c86f
to
873db7c
Compare
3f66376
to
2330dbc
Compare
873db7c
to
b2512a9
Compare
a8f5762
to
7f3efa4
Compare
b2512a9
to
1d807fb
Compare
7f3efa4
to
8264708
Compare
1d807fb
to
02e6652
Compare
8264708
to
ea03cd5
Compare
02e6652
to
6b13db1
Compare
ea03cd5
to
5494298
Compare
043d3bd
to
cc487b0
Compare
7d36613
to
e774f8b
Compare
cc487b0
to
6d8806b
Compare
e774f8b
to
8380fa9
Compare
7bee98a
to
92462b6
Compare
8380fa9
to
41e4e93
Compare
92462b6
to
6c8b85e
Compare
41e4e93
to
d651fd7
Compare
c127aff
to
604d3de
Compare
7c316ec
to
b43771a
Compare
1a6e91d
to
dcc048c
Compare
b43771a
to
6c146c1
Compare
dcc048c
to
0301869
Compare
6c146c1
to
94e1267
Compare
0301869
to
bb1282e
Compare
55d1497
to
0725655
Compare
This PR is a result of splitting #48843 into smaller PRs, and invokes the Azure sync functionality with a new Azure fetcher in the Discovery service.