[v16] Bump connectrpc.com/connect to 1.16.2 #44725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a panic that occurs if an unmarshaling error is handled during the processing of an error to a unary request.
espadolini
added
the
no-changelog
|
The panic was introduced in connectrpc/connect-go#659 and fixed (without a changelog entry 😭) in connectrpc/connect-go#711 (see connectrpc/connect-go#711 (comment)) |
taraspos
reviewed
Jul 29, 2024
bl-nero
approved these changes
Jul 29, 2024
taraspos
approved these changes
Jul 29, 2024
rosstimothy
approved these changes
Jul 29, 2024
public-teleport-github-review-bot
bot
removed the request for review
from probakowski
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a panic that occurs if an unmarshaling error is handled during the processing of an error to a unary request. This panic only occurs when using the connectrpc protocol, not grpc, so I believe that this can only affect the auths in Cloud (which is where we got this panic).