-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LICENSE and remove license header from source files #1960
Conversation
@@ -1,6 +1,6 @@ | |||
MIT License | |||
|
|||
Copyright (c) Facebook, Inc. and its affiliates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied from graphql-faq
repository: https://github.com/graphql/faq/blob/954d07c108634ebed1414b3380c830498bb0bbb6/LICENSE#L3
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @flow strict | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the source code for a couple of other projects under LF (Node.js, ESLint, esprima) and they just just have LICENSE at the root of the project and no license headers inside the source code.
Those headers add some inconvenience in the development process e.g. new contributors forget to add them, old PRs contains an old version of the license text, it's harder to diff and revert old commits, etc.
Plus they effectively double up the size of NPM package:
npm notice package size: 483.3 kB
npm notice unpacked size: 3.6 MB
VS
npm notice package size: 237.5 kB
npm notice unpacked size: 1.7 MB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus they effectively double up the size of NPM package:
I mad mistake during measurement, in reality, it was around ~100 kB difference unpacked.
@leebyron As a followup from last WG I created this PR. |
sorry can you just switch to plain old BSD-3? no need to switch to MIT, keep everything the same license |
MIT is fine I was just aiming for consistency
…On Mon, Jun 10, 2019 at 2:40 PM Ivan Goncharov ***@***.***> wrote:
@caniszczyk <https://github.com/caniszczyk> Thanks for the review 👍
sorry can you just switch to plain old BSD-3? no need to switch to MIT,
keep everything the same license
At the moment, almost all projects under GraphQL organization are licensed
as MIT:
https://github.com/graphql/libgraphqlparser/blob/master/LICENSE
https://github.com/graphql/graphql-relay-js/blob/master/LICENSE
https://github.com/graphql/dataloader/blob/master/LICENSE
https://github.com/graphql/faq/blob/master/LICENSE
https://github.com/graphql/graphiql/blob/master/LICENSE
https://github.com/graphql/graphql-js/blob/master/LICENSE
Only two repos are under BSD+Patents:
https://github.com/graphql/codemirror-graphql/blob/master/LICENSE
https://github.com/graphql/express-graphql/blob/master/LICENSE
And another two repo is under some strange licenses:
https://github.com/graphql/swapi-graphql/blob/master/LICENSE-examples
https://github.com/graphql/graphql-language-service/blob/master/LICENSE
Also, licenses were explicitly switched by Lee, as described here:
***@***.***/relicensing-the-graphql-specification-e7d07a52301b
Additionally, our reference implementation GraphQL.js and client-side
framework Relay will be relicensed under the MIT license,
So it would be easier to stick with MIT since it what we already used on
most of the projects (6 vs 2) and also since it was long promised to the
community.
Is there any reason why we can't use MIT for GraphQL Foundation projects?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1960?email_source=notifications&email_token=AAAPSIMLFSFUUV2UL3WUINLPZ2U35A5CNFSM4HVX4JPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLAIDI#issuecomment-500565005>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAPSILWWCMXJLRU53PHMXLPZ2U35ANCNFSM4HVX4JPA>
.
--
Cheers,
Chris Aniszczyk
http://aniszczyk.org
+1 512 961 6719
|
@caniszczyk Thanks for the quick reply 👍 Does it mean I can merge both PRs? |
just make sure the copyright is attributed to "GraphQL Contributors"
…On Mon, Jun 10, 2019 at 3:09 PM Ivan Goncharov ***@***.***> wrote:
@caniszczyk <https://github.com/caniszczyk> Thanks for the quick reply 👍
Does it mean I can merge both PRs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1960?email_source=notifications&email_token=AAAPSINGGIPJ3PFFAMYWXSTPZ2YG5A5CNFSM4HVX4JPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLCXFA#issuecomment-500575124>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAPSIOG5WMI7HFU23RND3LPZ2YG5ANCNFSM4HVX4JPA>
.
--
Cheers,
Chris Aniszczyk
http://aniszczyk.org
+1 512 961 6719
|
28d8bfd
to
7f14d6e
Compare
@caniszczyk Done. Thanks for a fast review 👍 |
@caniszczyk Can we apply the same LICENSE changes to all other projects under this organization? |
No description provided.