render: only encodeHeader() for svg output #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes graphite-project#1309 which points out that 08be1ba added this odd out-of-bounds "header" just for svg metadata
piotr1212
approved these changes
Apr 14, 2020
|
I finally got around to testing with a real setup, seems to work. I also prepared a super-trivial example of png and svg with this change: https://www.ploxiln.net/adhoc/render.png pdf output is a bit garbled for me, but seems to be garbled the same with graphite-web-1.1.5 which I still have running somewhere. seems the main problem may be the overall width/height? anyway I'm pretty sure it is unrelated (and I don't know the contexts in which pdf output is used) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1309
which points out that 08be1ba added this
odd out-of-bounds "header" just for svg metadata