build and smoke checkers #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szkiba
requested review from
pablochacin
and removed request for
a team and
pablochacin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version adds two new checkers to the linter:
build checker
The check is successful if the extension can be built with the latest k6 release.
smoke checker
The check is successful if there is a smoke test script and it runs successfully with the k6 built with the extension.
Obviously, a prerequisite for a successful run is that the build checker runs successfully, otherwise k6 cannot be built with the extension.
The smoke test script file is searched for in the root of the repository and in the
test,tests,examplesdirectories. The name of the smoke test script is one of the following:smoke.jssmoke.tssmoke.test.jssmoke.test.tsCloses #10 #9