Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add topologySpreadConstraints pod configuration #337

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Nov 14, 2023

Fixes #336

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2023

CLA assistant check
All committers have signed the CLA.

@aslafy-z aslafy-z changed the title feat: add topologySpreadConstraints runner configuration feat: add topologySpreadConstraints pod configuration Nov 14, 2023
@aslafy-z aslafy-z marked this pull request as ready for review November 14, 2023 13:24
Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aslafy-z, PR looks fine to me 👍 Just one request: could you please add a sample to config/samples folder? Something simple based on how you're going to use topologySpreadConstraints in your setup will do 🙂

Comment on lines +25 to +29
- description: TestRun is the Schema for the testruns API
displayName: Test Run
kind: TestRun
name: testruns.k6.io
version: v1alpha1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I suppose this came from running make bundle? We don't support operator-sdk bundle now: I guess that's why this definition slipped through the radar...

(It should be fine to merge this change, I just find it curious this file wasn't updated before.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is how I regenerated the bundles.

Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @aslafy-z!

@yorugac yorugac merged commit 08440fe into grafana:main Nov 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for topologySpreadConstraints
3 participants