-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add topologySpreadConstraints pod configuration #337
Conversation
Signed-off-by: GitHub <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aslafy-z, PR looks fine to me 👍 Just one request: could you please add a sample to config/samples
folder? Something simple based on how you're going to use topologySpreadConstraints
in your setup will do 🙂
- description: TestRun is the Schema for the testruns API | ||
displayName: Test Run | ||
kind: TestRun | ||
name: testruns.k6.io | ||
version: v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I suppose this came from running make bundle
? We don't support operator-sdk bundle now: I guess that's why this definition slipped through the radar...
(It should be fine to merge this change, I just find it curious this file wasn't updated before.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this is how I regenerated the bundles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, @aslafy-z!
Fixes #336