Fixed linter

* use the latest version of golangci-lint in github actions
* add the target of lint in Makefile
* fix nolint errcheck

.github/workflows/golangci-lint.yaml

@@ -1,5 +1,5 @@
 ---
-name: "golangci-lint"
+name: "Golang Lint"
 on:
   - push
   - pull_request
@@ -16,5 +16,5 @@ jobs:
       - name: lint
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.54
-          args: --timeout=30m
+          version: v1.55
+          args: --timeout=5m

Makefile

@@ -98,6 +98,10 @@ fmt:
 vet:
 	go vet ./...
 
+# Run golangci-lint
+lint:
+	go install github.com/golangci/golangci-lint/cmd/[email protected]
+	golangci-lint --timeout 5m run ./...
 # Generate code
 generate: controller-gen
 	$(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./..."

controllers/testrun_controller.go

@@ -268,7 +268,7 @@ func (r *TestRunReconciler) reconcile(ctx context.Context, req ctrl.Request, log
 		// delete if configured
 		if k6.GetSpec().Cleanup == "post" {
 			log.Info("Cleaning up all resources")
-			r.Delete(ctx, k6) //nolint:errcheck
+			_ = r.Delete(ctx, k6)
 		}
 		// notify if configured
 		return ctrl.Result{}, nil

main.go

@@ -89,8 +89,8 @@ func main() {
 		os.Exit(1)
 	}
 
-	mgr.AddHealthzCheck("health", healthz.Ping) //nolint:errcheck
-	mgr.AddReadyzCheck("ready", healthz.Ping)   //nolint:errcheck
+	_ = mgr.AddHealthzCheck("health", healthz.Ping)
+	_ = mgr.AddReadyzCheck("ready", healthz.Ping)
 
 	if err = (controllers.NewK6Reconciler(&controllers.TestRunReconciler{
 		Client: mgr.GetClient(),