Fix: Initialise default namespaces map config #5424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpaschalis
reviewed
Oct 10, 2023
| @@ -97,7 +97,9 @@ func (ctrl *eventController) runError(ctx context.Context) error { | |||
| } | |||
|
|
|||
| defaultNamespaces := map[string]cache.Config{} | |||
| defaultNamespaces[ctrl.task.Namespace] = cache.Config{} | |||
| if ctrl.task.Namespace != "" { | |||
There was a problem hiding this comment.
Should we not initialise the map if the string is empty (and move the initialization inside this if clause?
tpaschalis
pushed a commit
to tpaschalis/agent
that referenced
this pull request
Oct 10, 2023
(cherry picked from commit 37c40cc)
tpaschalis
added a commit
that referenced
this pull request
Oct 10, 2023
(cherry picked from commit 37c40cc) Co-authored-by: William Dumont <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Initialise a map to prevent panic