prometheus.operator.servicemonitors #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captncraig
changed the title
|
Implements #3384 |
You'd need add that to the description of the PR in order to get the related issue closed |
marctc
reviewed
Apr 26, 2023
|
|
||
| // Update implements component.Component. | ||
| func (c *Component) Update(args component.Arguments) error { | ||
| // TODO(jcreixell): Initialize manager here so we can return errors back early to the caller. |
There was a problem hiding this comment.
WDYT to address this TODO in this PR?
marctc
reviewed
Apr 26, 2023
marctc
reviewed
Apr 26, 2023
marctc
reviewed
Apr 26, 2023
marctc
reviewed
Apr 26, 2023
component/prometheus/operator/configgen/config_gen_serviceMonitor.go
Outdated
Show resolved
Hide resolved
marctc
reviewed
Apr 26, 2023
component/prometheus/operator/servicemonitors/serviceMonitors.go
Outdated
Show resolved
Hide resolved
jcreixell
reviewed
Apr 26, 2023
| } | ||
|
|
||
| func NewCRDManager(opts component.Options, logger log.Logger, args *Arguments) *crdManager { | ||
| const ( | ||
| KindPodMonitor string = "podMonitor" |
There was a problem hiding this comment.
we may want to define these constants in component.go (potentially with a type alias) and reference them here to prevent duplication and inconsistencies
jcreixell
reviewed
Apr 26, 2023
| func (c *crdManager) configureInformers(ctx context.Context, informers cache.Informers) error { | ||
| podMonitor := &promopv1.PodMonitor{} | ||
| var proto client.Object |
There was a problem hiding this comment.
would object or k8sObject be a more descriptive name?
thampiotr
pushed a commit
that referenced
this pull request
May 2, 2023
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #3384