-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Agones to 1.29.0 and Open Match to 1.7.0 #20
Conversation
I'll assign review after 3/7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the helm section. |
@kemurayama Thank you |
Hi @govargo I mentioned this line. Thanks. |
Thank you for your point out @kemurayama. It's my fault. I fixed this duplicate line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @govargo, thanks for updating. LGTM
This PR has a upgrade to Agones and Open Match and change of installing for Open Match
※1 One of the Open Match installing way is YAML apply. The default YAML requires more than 4.5 cpu cores, because the StatefulSet's Redis has 3 containers(redis, sentinel, metrics) requre each 0.5 cpus(= total 1.5 cores) and StatefulSet has 3 reqlica(= 1.5cores * 3Pod = total 4.5 cores)