Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nglviewer and fix leaflet. #14

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Conversation

blois
Copy link
Collaborator

@blois blois commented Sep 25, 2021

A couple of tweaks to fix nglviewer and fix leaflet:

  • nglviewer expects the binary buffers to always be set (an empty array as opposed to undefined). For nglviewer does not work #13.
  • nglviewer uses jQuery UI's ui.resizable extension which needs the root element to have width when initially created. Changed the root element to block styling to fix this. For nglviewer does not work #13.
  • Added a placeholder shim for pWidget to improve compatibility with jupyter-widgets 4.0.0 until we get more complete support (or until 5.0 goes stable). Fix for leafmap buttons have incorrect sizing #12.
    image

@blois blois merged commit 3f2e6f9 into googlecolab:main Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants