Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: support Pythons <4 #1413

Merged
merged 1 commit into from
Nov 17, 2022
Merged

deps: support Pythons <4 #1413

merged 1 commit into from
Nov 17, 2022

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Nov 16, 2022

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1412 🦕

@cpcloud cpcloud requested a review from a team November 16, 2022 19:32
@cpcloud cpcloud requested a review from a team as a code owner November 16, 2022 19:32
@cpcloud cpcloud requested a review from loferris November 16, 2022 19:32
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Nov 16, 2022
@cpcloud
Copy link
Contributor Author

cpcloud commented Nov 17, 2022

cc @tswast

@tswast
Copy link
Contributor

tswast commented Nov 17, 2022

@cpcloud I'm looking into this. It would be a departure from most of the other Google client libraries. Would you mind sharing some of the reasoning here why it's important to have a wider upper bound?

I assume partially it's so it's easier to test with prerelease versions of Python?

@cpcloud
Copy link
Contributor Author

cpcloud commented Nov 17, 2022

@tswast The main reason is for testing new Python versions not necessarily pre-release only though, since 3.11 has been out for about a month.

setup.py Outdated Show resolved Hide resolved
@cpcloud
Copy link
Contributor Author

cpcloud commented Nov 17, 2022

Should I put fix: prefix so that a release will be cut?

@cpcloud
Copy link
Contributor Author

cpcloud commented Nov 17, 2022

Seems the CLA check is failing, but I have signed one according to the link.

@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2022
@chalmerlowe
Copy link
Collaborator

chalmerlowe commented Nov 17, 2022

@cpcloud
Regarding the CLA check:

GH associated my gmail account with the change and NOT my google account and despite being a Googler and having my google address associated with my GH account, the CLA check only sees that [email protected] made the suggested change and co-authored a minor tweak. I am looking into how to reset the author on that change I suggested so that we can get past the CLA problem.
Sigh.

I attempted to reset the author using git on my local machine and push that change to GH, but it might have been pushed to your GH repo due to the various convolutions involved in pull requests, etc.

Sigh.

@cpcloud
Copy link
Contributor Author

cpcloud commented Nov 17, 2022

@chalmerlowe I went ahead and squashed it down to just myself as the author.

@chalmerlowe
Copy link
Collaborator

@chalmerlowe I went ahead and squashed it down to just myself as the author.

sweet. thanks.
once the tests pass, I will merge the change.

@dandhlee dandhlee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 17, 2022
@tswast tswast changed the title chore(setup.py): support Pythons <4 deps: support Pythons <4 Nov 17, 2022
@tswast
Copy link
Contributor

tswast commented Nov 17, 2022

Should I put fix: prefix so that a release will be cut?

I think that'd be appropriate. I recall that deps will also show up in the changelog, so should also trigger a release.

Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit cbab5ac into googleapis:main Nov 17, 2022
@cpcloud
Copy link
Contributor Author

cpcloud commented Nov 17, 2022

Thanks y'all!

@kevinfgordon
Copy link

@cpcloud thank you for this adjustment, I ran into the same issue trying to leverage this with 3.11 today. Eagerly awaiting the release to be completed.
FYI: The readme still references < 3.11 incase that should be adjusted to reflect the new change.

jumbosushi added a commit to jumbosushi/python-bigquery that referenced this pull request Feb 21, 2023
With googleapis#1413, python < 4 are all supported. Updating the README to communicate this (I had to look around before upgrading to 3.11)
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Pythons <4
6 participants