-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: support Pythons <4 #1413
deps: support Pythons <4 #1413
Conversation
cc @tswast |
@cpcloud I'm looking into this. It would be a departure from most of the other Google client libraries. Would you mind sharing some of the reasoning here why it's important to have a wider upper bound? I assume partially it's so it's easier to test with prerelease versions of Python? |
@tswast The main reason is for testing new Python versions not necessarily pre-release only though, since 3.11 has been out for about a month. |
Should I put |
Seems the CLA check is failing, but I have signed one according to the link. |
@cpcloud GH associated my gmail account with the change and NOT my google account and despite being a Googler and having my google address associated with my GH account, the CLA check only sees that [email protected] made the suggested change and co-authored a minor tweak. I am looking into how to reset the author on that change I suggested so that we can get past the CLA problem. I attempted to reset the author using git on my local machine and push that change to GH, but it might have been pushed to your GH repo due to the various convolutions involved in pull requests, etc. Sigh. |
@chalmerlowe I went ahead and squashed it down to just myself as the author. |
sweet. thanks. |
I think that'd be appropriate. I recall that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks y'all! |
@cpcloud thank you for this adjustment, I ran into the same issue trying to leverage this with 3.11 today. Eagerly awaiting the release to be completed. |
With googleapis#1413, python < 4 are all supported. Updating the README to communicate this (I had to look around before upgrading to 3.11)
Fixes #1412 🦕