Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reverted noxfile #1026

Closed
wants to merge 56 commits into from
Closed

test: reverted noxfile #1026

wants to merge 56 commits into from

Conversation

chalmerlowe
Copy link
Collaborator

testing for some test speedups....

sharoonthomas and others added 30 commits November 7, 2023 15:07
This patch makes this library backward incompatible for
versions of SQLAlchemy < 2.0.

Fixes #510
kiraksi and others added 26 commits December 18, 2023 13:49
…entries and potential implicit joins due to identical table names
* chore: remove code for sqlalchemy before 1_4

* reformatted with black:

* Removed sqlalchemy compliance tests from versions before 1.4

* removed code in base.py for sqlalchemy < 1.4

* fix coverage issues in base.py

* temporarily commented out code lines not passing coverage for testing purposes

* replaced functions previously removed for not passing cover

* testing removing functions for coverage

* add no cover tag to untested code and clean up commented out functions

* fix lint issues

* black

* chore: cleanup compliance file tests after migration

* lint

* fixed small import error

---------

Co-authored-by: Sharoon Thomas <[email protected]>
* chore: remove code for sqlalchemy before 1_4

* reformatted with black:

* Removed sqlalchemy compliance tests from versions before 1.4

* removed code in base.py for sqlalchemy < 1.4

* fix coverage issues in base.py

* temporarily commented out code lines not passing coverage for testing purposes

* replaced functions previously removed for not passing cover

* testing removing functions for coverage

* add no cover tag to untested code and clean up commented out functions

* fix lint issues

* black

* Readded deleted tests and renamed them from deprecated names

* black

---------

Co-authored-by: Sharoon Thomas <[email protected]>
* chore: remove code for sqlalchemy before 1_4

* reformatted with black:

* Removed sqlalchemy compliance tests from versions before 1.4

* removed code in base.py for sqlalchemy < 1.4

* fix coverage issues in base.py

* temporarily commented out code lines not passing coverage for testing purposes

* replaced functions previously removed for not passing cover

* testing removing functions for coverage

* add no cover tag to untested code and clean up commented out functions

* fix lint issues

* black

* Readded deleted tests and renamed them from deprecated names

* black

* chore: sqlalchemy test compliance suite cleanup code

* black

* black

---------

Co-authored-by: Sharoon Thomas <[email protected]>
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Feb 6, 2024
@chalmerlowe chalmerlowe closed this Feb 7, 2024
@chalmerlowe chalmerlowe deleted the xdist-tests-0 branch February 7, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants