-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: to_gbq
allows strings for DATE and floats for NUMERIC, require pandas 0.24+ and db-dtypes
#423
Conversation
…igquery-pandas into issue362-to_gbq-date
…MERIC This improves `api_method="load_parquet"` compatibility with the previous `api_method="load_csv"` behavior.
Need to package db-dtypes package in order to pass conda session. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few things worth double-checking, but the general picture looks good.
Possible we need to adjust NULLABLE_INT_PANDAS_VERSION |
to_gbq
allows strings for DATE and floats for NUMERIC, require pandas 0.24+ and db-dtypes
Marking as DO NOT MERGE as a reminder to make sure
is included as a footer to the PR, as I'd like to see if we can use this feature: googleapis/release-please#686 |
Per googleapis/release-please#821, the extra metadata isn't important. It's that the extra commits are listed as a footer to the commit message without anything in-between. |
Ready for (re)review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks for the cleanup!
The nightly test failure is probably flakiness? The logs say "killed"? |
Nightly failure isn't even flakey. It always fails because the conda package installation times out. #424 Switching to |
🤖 I have created a release *beep* *boop* --- ## [0.17.0](v0.16.0...v0.17.0) (2022-01-19) ### ⚠ BREAKING CHANGES * use nullable Int64 and boolean dtypes if available (#445) ### Features * accepts a table ID, which downloads the table without a query ([#443](#443)) ([bf0e863](bf0e863)) * use nullable Int64 and boolean dtypes if available ([#445](#445)) ([89078f8](89078f8)) ### Bug Fixes * `read_gbq` supports extreme DATETIME values such as `0001-01-01 00:00:00` ([#444](#444)) ([d120f8f](d120f8f)) * `to_gbq` allows strings for DATE and floats for NUMERIC with `api_method="load_parquet"` ([#423](#423)) ([2180836](2180836)) * allow extreme DATE values such as `datetime.date(1, 1, 1)` in `load_gbq` ([#442](#442)) ([e13abaf](e13abaf)) * avoid iteritems deprecation in pandas prerelease ([#469](#469)) ([7379cdc](7379cdc)) * use data project for destination in `to_gbq` ([#455](#455)) ([891a00c](891a00c)) ### Miscellaneous Chores * release 0.17.0 ([#470](#470)) ([29ac8c3](29ac8c3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
deps: require pandas 0.24+ and db-dtypes for TIME/DATE extension dtypes
Review #420 first! This PR is based on changes to the system tests introduced there.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #421 🦕