Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve gbq.py code coverage #19

Merged
merged 1 commit into from
Mar 4, 2017
Merged

Improve gbq.py code coverage #19

merged 1 commit into from
Mar 4, 2017

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Mar 4, 2017

Closes #6

jreback
jreback approved these changes Mar 4, 2017
View reviewed changes
pandas_gbq/gbq.py
@@ -97,6 +97,15 @@ class InvalidColumnOrder(PandasError, ValueError):
pass


class InvalidIndexColumn(PandasError, ValueError):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is new, yes? add in the changelog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@parthea parthea force-pushed the improve-code-coverage branch from 935960e to 18087a9 Compare March 4, 2017 18:13
@codecov-io
Copy link

Codecov Report

Merging #19 into master will increase coverage by 1.47%.
The diff coverage is 94.87%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   75.08%   76.56%   +1.47%     
==========================================
  Files           4        4              
  Lines        1457     1519      +62     
==========================================
+ Hits         1094     1163      +69     
+ Misses        363      356       -7
Impacted Files Coverage Δ
pandas_gbq/gbq.py 79.14% <100%> (+2.22%) ✅
pandas_gbq/tests/test_gbq.py 86.65% <94.52%> (+0.62%) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcbc319...18087a9. Read the comment docs.

@parthea parthea merged commit 68873ed into master Mar 4, 2017
@jreback
Copy link
Contributor

jreback commented Mar 4, 2017

great thanks!

@parthea parthea deleted the improve-code-coverage branch April 7, 2017 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthea @codecov-io @jreback