BUG: only show verbose warning for new pandas versions. #158
Conversation
pandas_gbq/gbq.py
Outdated
| pandas_installed_version = pkg_resources.get_distribution( | ||
| 'pandas').parsed_version | ||
| pandas_version_wo_verbosity = pkg_resources.parse_version('0.23.0') | ||
| PANDAS_HAS_DEPRECATED_VERBOSITY = ( |
There was a problem hiding this comment.
F841 local variable 'PANDAS_HAS_DEPRECATED_VERBOSITY' is assigned to but never used
There was a problem hiding this comment.
Just amended the commit to add the global declaration.
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
===========================================
- Coverage 79.22% 36.53% -42.69%
===========================================
Files 10 10
Lines 1545 1549 +4
===========================================
- Hits 1224 566 -658
- Misses 321 983 +662
Continue to review full report at Codecov.
|
|
@tswast great tests! Though did you see the build now fails? Only a mock issue, not functionality |
|
Ah, I missed that. Weird that it's only on Py 3.5. I'll follow-up. |
|
I couldn't reproduce locally. I think the root issue was a conflict between pip and conda. Fixed in #160. |
Closes #157
(Assumes pandas-dev/pandas#20564 will go in before Pandas 0.23.0 release)
/cc @craigcitro