TST: Add unit tests for pandas_gbq.auth.get_credentials(). #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests (actual auth mocked out): * Using private key with contents. * Using private key with path. * Using default credentials. * Using cached user credentials.
|
Failing on Python 2.7. I'm investigating. |
|
It's a mock issue. The Python 2.7 autospec seems to be getting confused by the use of a classmethod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests (actual auth mocked out):
Also, since I found it a little hard to debug the private key tests, update the error message with a little more information about what kind of credentials it thinks
private_keyis.Closes #49