Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Improve unit tests for GoogleCredentials.get_application_default() #49

Closed
parthea opened this issue Jun 7, 2017 · 0 comments
Closed
Assignees

Comments

@parthea
Copy link
Contributor

parthea commented Jun 7, 2017

The test test_get_application_default_credentials_returns_credentials() : https://github.com/pydata/pandas-gbq/blob/master/pandas_gbq/tests/test_gbq.py#L297 is skipped if _check_if_can_get_correct_default_credentials() returns false. This happens when default credentials are not available. In order to improve test coverage, specifically on Travis, we could (temporarily) populate the default credentials during testing in order to exercise the code that uses default credentials. We could unset the default credentials after testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants