-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): adds support for X509 workload identity federation #10373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeitzman
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jun 12, 2024
cc @andyrzhao |
codyoss
reviewed
Jun 12, 2024
codyoss
reviewed
Jun 12, 2024
…isibility into whether the client should be overriden
codyoss
changed the title
feat: adds support for X509 workload identity federation
feat(auth): adds support for X509 workload identity federation
Jun 24, 2024
@andyrzhao Would you mind looking at this too since you are active in this space. |
andyrzhao
reviewed
Jun 25, 2024
codyoss
approved these changes
Jun 27, 2024
andyrzhao
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
aeitzman
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.