Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GCS+gRPC): treat some kAlreadyExists errors as transient #9564

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 25, 2022

The service is (we think incorrectly) returning kAlreadyExists for
some uploads. We need a workaround to unblock some testing. The GCS
team is working on a fix in parallel.


This change is Reviewable

The service is (we think incorrectly) returning `kAlreadyExists` for
some uploads. We need a workaround to unblock some testing. The GCS
team is working on a fix in parallel.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 0f721ada4c4eb00f7a6c9f490423b7b1bc5df673

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #9564 (0f721ad) into main (71012ff) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #9564   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files        1491     1491           
  Lines      137569   137601   +32     
=======================================
+ Hits       129829   129860   +31     
- Misses       7740     7741    +1     
Impacted Files Coverage Δ
google/cloud/storage/internal/retry_client.cc 100.00% <100.00%> (ø)
google/cloud/storage/internal/retry_client_test.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/subscriber_connection_test.cc 97.75% <0.00%> (-0.57%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.49% <0.00%> (-0.17%) ⬇️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71012ff...0f721ad. Read the comment docs.

@coryan coryan marked this pull request as ready for review July 26, 2022 12:56
@coryan coryan requested a review from a team as a code owner July 26, 2022 12:56
@coryan coryan merged commit 29ff9d3 into googleapis:main Jul 26, 2022
@coryan coryan deleted the feat-GCS+gRPC-workaround-spurious-ALREADY-EXISTS-failures branch July 26, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants