Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix typo in testing_util/config.cmake.in #2851

Merged
merged 1 commit into from Jul 2, 2019
Merged

bug: Fix typo in testing_util/config.cmake.in #2851

merged 1 commit into from Jul 2, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 2, 2019

Sorry I didn't catch this earlier. Just caught it while trying to use find_package(google_cloud_cpp_testing CONFIG REQUIRED) in spanner.


This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2019
@coryan coryan added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #2851 into master will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2851      +/-   ##
==========================================
+ Coverage   89.18%   89.44%   +0.26%     
==========================================
  Files         292      292              
  Lines       19519    19519              
==========================================
+ Hits        17408    17459      +51     
+ Misses       2111     2060      -51
Impacted Files Coverage Δ
google/cloud/storage/oauth2/credentials.h 33.33% <0%> (-33.34%) ⬇️
google/cloud/bigtable/metadata_update_policy.h 71.42% <0%> (-28.58%) ⬇️
google/cloud/storage/well_known_headers.h 77.77% <0%> (-7.41%) ⬇️
google/cloud/storage/internal/generic_request.h 82.05% <0%> (ø) ⬆️
...storage/benchmarks/storage_throughput_benchmark.cc 82.15% <0%> (+0.41%) ⬆️
google/cloud/storage/object_stream.h 100% <0%> (+1.85%) ⬆️
google/cloud/bigtable/mutations.h 100% <0%> (+2.6%) ⬆️
google/cloud/storage/internal/object_requests.h 100% <0%> (+2.98%) ⬆️
google/cloud/storage/object_metadata.h 100% <0%> (+3.7%) ⬆️
google/cloud/storage/internal/curl_handle.h 77.41% <0%> (+12.9%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7182d0d...c9b53e3. Read the comment docs.

Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: We are missing some kind of test to detect these problems methinks.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@coryan coryan merged commit da7749b into googleapis:master Jul 2, 2019
@ghost ghost deleted the fix-testing-util-config-typo branch July 23, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants