Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otel): release GCM exporter #14693

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Sep 9, 2024

Fixes #14683


This change is Reviewable

@dbolduc dbolduc marked this pull request as ready for review September 10, 2024 16:01
@dbolduc dbolduc requested review from a team as code owners September 10, 2024 16:02
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.62%. Comparing base (9891e6a) to head (ee4b967).
Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
...oud/storage/internal/grpc/metrics_exporter_impl.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14693      +/-   ##
==========================================
- Coverage   93.62%   93.62%   -0.01%     
==========================================
  Files        2320     2320              
  Lines      207188   207178      -10     
==========================================
- Hits       193975   193964      -11     
- Misses      13213    13214       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dbolduc)

@dbolduc dbolduc merged commit 83eac5e into googleapis:main Sep 10, 2024
71 checks passed
@dbolduc dbolduc deleted the feat-gcm-exporter branch September 10, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release C++ OpenTelemetry Cloud Monitoring (GCM) Exporter
2 participants