Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigtable): sanitize RowRange proto input #14651

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 19, 2024

Sanitize input for the ctor from protos. Hopefully the comment in the code explains why we want to do this.
Also correct the documentation for this class.

I considered deprecating the constructor that takes a proto, but it is too complicated.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (cd1c047) to head (535cdbf).
Report is 129 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14651   +/-   ##
=======================================
  Coverage   90.91%   90.92%           
=======================================
  Files        1755     1755           
  Lines      133091   133106   +15     
=======================================
+ Hits       121004   121021   +17     
+ Misses      12087    12085    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review August 19, 2024 18:09
@dbolduc dbolduc requested a review from a team as a code owner August 19, 2024 18:09
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dbolduc)

@dbolduc dbolduc merged commit 22dcd19 into googleapis:main Aug 19, 2024
70 checks passed
@dbolduc dbolduc deleted the bigtable-row-range-sanitize-input branch August 19, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants