Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare for v2.11.0 release #11762

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jun 1, 2023

This change is Reviewable

Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dbolduc)


CHANGELOG.md line 133 at r1 (raw file):

The following experimental libraries are now available:

- [Compute Engine API](/google/cloud/compute/README.md)

Let's wait on announcing this until next month as only one service is currently present.

Code quote:

The following experimental libraries are now available:

- [Compute Engine API](/google/cloud/compute/README.md)

@dbolduc dbolduc marked this pull request as ready for review June 1, 2023 15:44
@dbolduc dbolduc requested a review from a team as a code owner June 1, 2023 15:44
CHANGELOG.md Outdated Show resolved Hide resolved
@dbolduc dbolduc force-pushed the changelog-v2-11-0 branch from bae5609 to 11154e7 Compare June 1, 2023 15:55
Copy link
Member Author

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @coryan and @scotthart)


CHANGELOG.md line 133 at r1 (raw file):

Previously, scotthart (Scott Hart) wrote…

Let's wait on announcing this until next month as only one service is currently present.

Good call. Done.


CHANGELOG.md line 153 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

I think you are missing #11754

Thanks. I forgot to rebase.

Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @coryan)

@dbolduc dbolduc enabled auto-merge (squash) June 1, 2023 16:07
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (18af25f) 93.79% compared to head (11154e7) 93.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11762   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files        1834     1834           
  Lines      165857   165857           
=======================================
  Hits       155562   155562           
  Misses      10295    10295           

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc merged commit 37a0603 into googleapis:main Jun 1, 2023
@dbolduc dbolduc deleted the changelog-v2-11-0 branch June 1, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants