Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): support Autoclass feature #10003

Merged
merged 3 commits into from
Oct 8, 2022
Merged

feat(storage): support Autoclass feature #10003

merged 3 commits into from
Oct 8, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 7, 2022 •
edited
Loading

This implements support for REST and gRPC, as well as the unit tests and the samples.

Fixes #9751

This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Oct 7, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: cc0c02439fbfc3e4f2b78ff32c55e36057a1a02e

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan
Copy link
Contributor Author

coryan commented Oct 7, 2022

/FYI @cojenco

@codecov
Copy link

codecov bot commented Oct 7, 2022 •
edited
Loading

Codecov Report

Base: 94.22% // Head: 94.22% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9fd0410) compared to base (dd47583).
Patch coverage: 95.23% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #10003    +/-   ##
========================================
  Coverage   94.22%   94.22%            
========================================
  Files        1517     1520     +3     
  Lines      141086   141293   +207     
========================================
+ Hits       132939   133140   +201     
- Misses       8147     8153     +6
Impacted Files Coverage Δ
google/cloud/testing_util/example_driver.cc 94.91% <25.00%> (-5.09%) ⬇️
...orage/examples/storage_bucket_autoclass_samples.cc 91.04% <91.04%> (ø)
...ud/storage/internal/grpc_bucket_metadata_parser.cc 92.46% <93.33%> (+0.03%) ⬆️
google/cloud/storage/bucket_autoclass.cc 100.00% <100.00%> (ø)
google/cloud/storage/bucket_autoclass.h 100.00% <100.00%> (ø)
google/cloud/storage/bucket_metadata.cc 99.08% <100.00%> (+0.02%) ⬆️
google/cloud/storage/bucket_metadata.h 100.00% <100.00%> (ø)
google/cloud/storage/bucket_metadata_test.cc 99.44% <100.00%> (+0.03%) ⬆️
...e/cloud/storage/internal/bucket_metadata_parser.cc 98.42% <100.00%> (+0.06%) ⬆️
...orage/internal/grpc_bucket_metadata_parser_test.cc 99.46% <100.00%> (+0.03%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review October 8, 2022 00:18
@coryan coryan requested a review from a team as a code owner October 8, 2022 00:18
@snippet-bot
Copy link

snippet-bot bot commented Oct 8, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: d43921f0a170a52febb852949720842d51c1efdb

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

dbolduc
dbolduc approved these changes Oct 8, 2022
View reviewed changes
google/cloud/storage/examples/storage_bucket_autoclass_samples.cc

if (!examples::UsingEmulator()) std::this_thread::sleep_until(pause);
(void)examples::RemoveBucketAndContents(client, bucket_name_enabled);
(void)examples::RemoveBucketAndContents(client, bucket_name_disabled);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want a pause in between these deletes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

coryan added 3 commits October 8, 2022 18:47
@coryan
feat(storage): support Autoclass feature
94e1e85 
This implements support for REST and gRPC, as well as the unit tests and
the samples.
@coryan
Fix formatting
b210695
@coryan
Address review comments
9fd0410
@coryan coryan force-pushed the feat-storage-implement-autoclass-support branch from 8c16c06 to 9fd0410 Compare October 8, 2022 18:47
@coryan coryan enabled auto-merge (squash) October 8, 2022 18:47
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 9fd04104af0f7d109502682007c1f57fb52b9039

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 315c752 into googleapis:main Oct 8, 2022
@coryan coryan deleted the feat-storage-implement-autoclass-support branch October 9, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbolduc dbolduc dbolduc approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage: add support for Autoclass
3 participants
@coryan @google-cloud-cpp-bot @dbolduc