Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Authentication_with_OAuth.ipynb #248

Closed
wants to merge 1 commit into from

Conversation

robinroy03
Copy link

The other URL is deprecated and gives a 404 now.

The other URL is deprecated and gives a 404 now.
Copy link

google-cla bot commented Jul 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:quickstarts Issues/PR referencing quickstarts folder labels Jul 28, 2024
@markmcd
Copy link
Member

markmcd commented Aug 15, 2024

I'm not sure this is the right fix. Models still must be named tunedModels/something, so the original syntax is still correct. If it is changed, the field should default to something containing the prefix tunedModels/ so it's clear what belongs there.

@markmcd markmcd added status:awaiting response Awaiting a response from the author and removed status:awaiting review PR awaiting review from a maintainer labels Aug 15, 2024
@robinroy03 robinroy03 closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:quickstarts Issues/PR referencing quickstarts folder status:awaiting response Awaiting a response from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants