Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflows: add CI github action workflow #4

Closed
wants to merge 2 commits into from

Conversation

hyangah
Copy link
Contributor

@hyangah hyangah commented Mar 11, 2020

Ideally I want the CI to run from Gerrit because that will be our primary change review system,
but the internal system is not ready yet.
This is a temporary solution that uses Github Action. The CI workflow kicks in for every PR and every commit on the master.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Mar 11, 2020
@gopherbot
Copy link
Collaborator

This PR (HEAD: 6b9b76d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/222921 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Rebecca Stambler:

Patch Set 1: Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/222921.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR (HEAD: 948b555) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/222921 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot pushed a commit that referenced this pull request Mar 11, 2020
Ideally I want the CI to run from Gerrit because that will be our primary change review system,
but the internal system is not ready yet.
This is a temporary solution that uses Github Action. The CI workflow kicks in for every PR and every commit on the master.

Change-Id: I97c9d20f4649c4cafd7a984c02fa84d0bc70f554
GitHub-Last-Rev: 948b555
GitHub-Pull-Request: #4
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/222921
Reviewed-by: Rebecca Stambler <[email protected]>
@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/222921.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/222921 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants