Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goMain: go.locate.tools command #14

Closed
wants to merge 3 commits into from
Closed

Conversation

hyangah
Copy link
Contributor

@hyangah hyangah commented Mar 19, 2020

This command prints the list of configured tools and paths to the tools.
I hope this is useful when debugging the cases where multiple versions
of a tool exist in different directories.

This command prints the list of configured tools and paths to the tools.
I hope this is useful when debugging the cases where multiple versions
of a tool exist in different directories.
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Mar 19, 2020
@gopherbot
Copy link
Collaborator

This PR (HEAD: a6e510f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/224098 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Ingo Oeser:

Patch Set 1:

(1 comment)

Great idea to display more information on that! I just have a small suggestion to make the output more actionable.


Please don’t reply on this GitHub thread. Visit golang.org/cl/224098.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Rebecca Stambler:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/224098.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR (HEAD: 4184fd3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/224098 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot pushed a commit that referenced this pull request Mar 20, 2020
This command prints the list of configured tools and paths to the tools.
I hope this is useful when debugging the cases where multiple versions
of a tool exist in different directories.

Change-Id: I925422e262978300cbccc97b53d547e4b2f4b146
GitHub-Last-Rev: 4184fd3
GitHub-Pull-Request: #14
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/224098
Reviewed-by: Rebecca Stambler <[email protected]>
@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/224098.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/224098 has been merged.

@gopherbot gopherbot closed this Mar 20, 2020
hyangah added a commit to hyangah/vscode-go-old that referenced this pull request Mar 20, 2020
This command prints the list of configured tools and paths to the tools.
I hope this is useful when debugging the cases where multiple versions
of a tool exist in different directories.

Change-Id: I925422e262978300cbccc97b53d547e4b2f4b146
GitHub-Last-Rev: 4184fd3
GitHub-Pull-Request: golang/vscode-go#14
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/224098
Reviewed-by: Rebecca Stambler <[email protected]>
ramya-rao-a pushed a commit to microsoft/vscode-go that referenced this pull request Mar 26, 2020
* goMain: go.locate.tools command

This command prints the list of configured tools and paths to the tools.
I hope this is useful when debugging the cases where multiple versions
of a tool exist in different directories.

Change-Id: I925422e262978300cbccc97b53d547e4b2f4b146
GitHub-Last-Rev: 4184fd3
GitHub-Pull-Request: golang/vscode-go#14
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/224098
Reviewed-by: Rebecca Stambler <[email protected]>

* src/goMain: avoid extra fs lookups in go.locate.tools

Address the comments from Ramya.

Change-Id: I3a0d6cb1dbb656ffb18da266b370c7e9bcf32b3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants