github/workflows: use <year>.<month>.<day>.<hour> as version #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marketplace does not allow prerelease annotation (but `vsce package` command allows it). Use the four digit semver instead. And record the commit hash to the CHANGELOG.md since we cannot rely on the version string to encode the info.
googlebot
added
the
cla: yes
|
This PR (HEAD: cf71291) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/223961 to see it. Tip: You can toggle comments from me using the |
|
Message from Hyang-Ah Hana Kim: Patch Set 1: ping? Please don’t reply on this GitHub thread. Visit golang.org/cl/223961. |
|
Message from Rebecca Stambler: Patch Set 1: Code-Review+2 Ah sorry I missed this, LGTM. Please don’t reply on this GitHub thread. Visit golang.org/cl/223961. |
gopherbot
pushed a commit
that referenced
this pull request
Mar 19, 2020
Marketplace does not allow prerelease annotation. That caused the release error like https://github.com/golang/vscode-go/runs/517074211?check_suite_focus=true Use the four digit semver instead. Note the current `vsce package` command allows prerelease annotation but does not allow four digit semver format currently. And record the commit hash to the CHANGELOG.md since we cannot rely on the version string to encode the info. Update #5 Change-Id: Id45fc822bb0d5b6b6750e28bf71bbb49f3eb97be GitHub-Last-Rev: cf71291 GitHub-Pull-Request: #12 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/223961 Reviewed-by: Rebecca Stambler <[email protected]>
|
This PR is being closed because golang.org/cl/223961 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketplace does not allow prerelease annotation.
That caused the release error like
https://github.com/golang/vscode-go/runs/517074211?check_suite_focus=true
Use the four digit semver instead. Note the current
vsce packagecommand allows prerelease annotation but does not allow four digit
semver format currently.
And record the commit hash to the CHANGELOG.md
since we cannot rely on the version string to encode the info.
Update #5