x/telemetry: crashes on windows-386

[adonovan]

Tests of https://go.dev/cl/558256 are failing spuriously due to crashes in the go command on windows-386 (decoding the hash table in the shared counter page). Example:

https://ci.chromium.org/ui/p/golang/builders/try/x_tools-gotip-windows-386/b8757239534114088753/test-results?q=ExactID%3Agolang.org%2Fx%2Ftools%2Fcmd%2Fcallgraph.TestCallgraph+VHash%3A36b5a8c990697350&clean=&sortby=&groupby=

Is this perhaps a file format version skew? Or a bug that has already been fixed in x/telemetry?

main_test.go:81: err: exit status 2: stderr: unexpected fault address 0x222700c0
        fatal error: fault
        [signal 0xc0000005 code=0x0 addr=0x222700c0 pc=0x7268b4]
        
        goroutine 1 gp=0x204a008 m=0 mp=0x12096a0 [running]:
        runtime.throw({0xdb5593, 0x5})
        	runtime/panic.go:1011 +0x4d fp=0x20b5b34 sp=0x20b5b20 pc=0x75eedd
        runtime.sigpanic()
        	runtime/signal_windows.go:414 +0x100 fp=0x20b5b58 sp=0x20b5b34 pc=0x775c50
        runtime/internal/atomic.Load(0x222700c0)
        	runtime/internal/atomic/atomic_386.go:19 +0x4 fp=0x20b5b5c sp=0x20b5b58 pc=0x7268b4
        sync/atomic.(*Uint32).Load(...)
        	sync/atomic/type.go:121
        cmd/vendor/golang.org/x/telemetry/internal/counter.(*mappedFile).load32(...)
        	cmd/vendor/golang.org/x/telemetry/internal/counter/file.go:534
        cmd/vendor/golang.org/x/telemetry/internal/counter.(*mappedFile).newCounter(0x213c060, {0x2106400, 0x19})
        	cmd/vendor/golang.org/x/telemetry/internal/counter/file.go:632 +0x43b fp=0x20b5bf0 sp=0x20b5b5c pc=0xce215b
        cmd/vendor/golang.org/x/telemetry/internal/counter.(*file).newCounter1(0x12085a0, {0x2106400, 0x19})
        	cmd/vendor/golang.org/x/telemetry/internal/counter/file.go:342 +0x194 fp=0x20b5c4c sp=0x20b5bf0 pc=0xce09a4
        cmd/vendor/golang.org/x/telemetry/internal/counter.(*file).newCounter(0x12085a0, {0x2106400, 0x19})
        	cmd/vendor/golang.org/x/telemetry/internal/counter/file.go:325 +0x2f fp=0x20b5c68 sp=0x20b5c4c pc=0xce07df
        cmd/vendor/golang.org/x/telemetry/internal/counter.(*file).lookup(0x12085a0, {0x2106400, 0x19})
        	cmd/vendor/golang.org/x/telemetry/internal/counter/file.go:107 +0x50 fp=0x20b5c8c sp=0x20b5c68 pc=0xcdee40
        cmd/vendor/golang.org/x/telemetry/internal/counter.(*Counter).releaseLock(0x2129dc0, 0xffffffff)
        	cmd/vendor/golang.org/x/telemetry/internal/counter/counter.go:224 +0x1d7 fp=0x20b5d00 sp=0x20b5c8c pc=0xcde107
        cmd/vendor/golang.org/x/telemetry/internal/counter.(*Counter).Add(0x2129dc0, 0x1)
        	cmd/vendor/golang.org/x/telemetry/internal/counter/counter.go:178 +0x4fd fp=0x20b5d80 sp=0x20b5d00 pc=0xcdd9fd
        cmd/vendor/golang.org/x/telemetry/internal/counter.(*Counter).Inc(0x2129dc0)
        	cmd/vendor/golang.org/x/telemetry/internal/counter/counter.go:130 +0x2f fp=0x20b5d90 sp=0x20b5d80 pc=0xcdd4ef
        main.invoke.CountFlags.func3(0x2112ee0)
        	cmd/vendor/golang.org/x/telemetry/counter/counter.go:92 +0x5e fp=0x20b5db0 sp=0x20b5d90 pc=0xce49ee
        flag.(*FlagSet).Visit(0x20b5e50, 0x20b5eb0)
        	flag/flag.go:472 +0x4a fp=0x20b5dd0 sp=0x20b5db0 pc=0x83f54a
        cmd/vendor/golang.org/x/telemetry/counter.CountFlags(...)
        	cmd/vendor/golang.org/x/telemetry/counter/counter.go:91
        main.invoke(0x1201a20, {0x2076008, 0xb, 0xf})
        	cmd/go/main.go:244 +0x468 fp=0x20b5ed8 sp=0x20b5dd0 pc=0xce4688
        main.main()
        	cmd/go/main.go:180 +0x8e7 fp=0x20b5fac sp=0x20b5ed8 pc=0xce3ea7

[bcmills]

Quim sent a revert for this in https://go.dev/cl/560655.

[gopherbot]

Change https://go.dev/cl/560655 mentions this issue: Revert "cmd/go: add telemetry counters for flag names and subcommand"

[findleyr]

Let's reopen this to track fixing the underlying issue on windows/386. CC @pjweinb

[gopherbot]

Change https://go.dev/cl/561995 mentions this issue: telemetry: extend to 386 systems