Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: add a Go GC guide #53360

Closed
mknyszek opened this issue Jun 13, 2022 · 3 comments
Closed

x/website: add a Go GC guide #53360

mknyszek opened this issue Jun 13, 2022 · 3 comments
Assignees
@mknyszek
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker website
Milestone
Go1.19

Comments

@mknyszek
Copy link
Contributor

As part of #48409 I proposed adding a new guide for the Go GC. This is an issue to track that work.
@mknyszek mknyszek self-assigned this Jun 13, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jun 13, 2022
@mknyszek mknyszek modified the milestones: Unreleased, Go1.19 Jun 13, 2022
@mknyszek mknyszek added NeedsFix The path to resolution is known, but the work has not been done. Documentation Issues describing a change to documentation. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 labels Jun 13, 2022
@mknyszek mknyszek mentioned this issue Jun 13, 2022
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/411954 mentions this issue: _content/doc: add work-in-progress gc-guide.html

gopherbot pushed a commit to golang/website that referenced this issue Jun 13, 2022
@mknyszek
_content/doc: add work-in-progress gc-guide.html
a752210 
Currently we're publishing links to go.dev/doc/gc-guide but these links
are broken. I'm currently working on this, but at the very least let's
publish a work-in-progress page so that the status is clearer to those
who click the link.

For golang/go#53360.
Fixes golang/go#53337.

Change-Id: Id3c6107d25ce9980e88d53c8ba6ec5b4349aa29f
Reviewed-on: https://go-review.googlesource.com/c/website/+/411954
Reviewed-by: Michael Pratt <[email protected]>
Run-TryBot: Michael Knyszek <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@mknyszek
Copy link
Contributor Author

Note for release folks: I marked this as a release blocker because we have outstanding links to this guide and work-in-progress page that mentions expected availability around the time of the 1.19 release.

However, this is not a hard blocker. If need be, we can drop this and update the work-in-progress page with a new expectation. I fully intend to have it ready before then, but if for some reason that becomes impossible, this issue is still useful for tracking the work to either update that work-in-progress page, or delete the links (from the SetMemoryLimit documentation, added in Go 1.19, and the Go 1.19 release notes).

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/414397 mentions this issue: _content/doc: add GC guide for Go 1.19

@gopherbot gopherbot moved this to Done in Release Blockers Jul 12, 2022
@golang golang locked and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mknyszek mknyszek

Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker website
Projects
Release Blockers
Status: Done
Milestone
Go1.19
Development

No branches or pull requests
2 participants
@mknyszek @gopherbot